Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9763. long string tooltip applied statically to components #9793

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix #9763. long string tooltip applied statically to components #9793

merged 3 commits into from
Dec 6, 2023

Conversation

offtherailz
Copy link
Member

@offtherailz offtherailz commented Dec 6, 2023 •
edited
Loading

Description

This PR fixes a couple of problems:

The issues are solved by apply the wrapper statically to the effective formatters needed.
This makes:

  • the formatter to not be generated on every render, with performance and stability of references improved. This fixes also the problem with the editor.
  • the formatter not to be applied to every formatter found, but only to the standard and tested ones (string, number, date). Boolean was not necessary because cell never goes below the size of including true/false string.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz added Internal BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Dec 6, 2023
@offtherailz offtherailz added this to the 2023.02.01 milestone Dec 6, 2023
@offtherailz offtherailz self-assigned this Dec 6, 2023
@tdipisa tdipisa requested a review from MV88 December 6, 2023 11:15
@MV88 MV88 enabled auto-merge (squash) December 6, 2023 11:18
@MV88 MV88 merged commit eefad42 into geosolutions-it:master Dec 6, 2023
5 checks passed
@offtherailz
Copy link
Member Author

@ElenaGallo, could you please test this on DEV ? Thank you

offtherailz added a commit that referenced this pull request Dec 6, 2023
@offtherailz
Fix #9763. long string tooltip applied statically to components (#9793)
9a6c179 
* Fix #9763. long string tooltip applied statically to components

* Fixed tests
@offtherailz offtherailz mentioned this pull request Dec 6, 2023
Merged
@ElenaGallo
Copy link
Contributor

Test passed, @offtherailz please backport to 2023.02.xx. thanks

MV88 pushed a commit that referenced this pull request Dec 6, 2023
@offtherailz
Fix #9763. long string tooltip applied statically to components (#9793)…
1b47e22 
… (#9794)

* Fix #9763. long string tooltip applied statically to components

* Fixed tests
@ElenaGallo ElenaGallo added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Dec 6, 2023
mahmoudadel54 pushed a commit to mahmoudadel54/MapStore2 that referenced this pull request Dec 7, 2023
@offtherailz @mahmoudadel54
Fix geosolutions-it#9763. long string tooltip applied statically to c…
ba18b9b 
…omponents (geosolutions-it#9793)

* Fix geosolutions-it#9763. long string tooltip applied statically to components

* Fixed tests
@mahmoudadel54 mahmoudadel54 mentioned this pull request Dec 7, 2023
Merged
MV88 pushed a commit that referenced this pull request Dec 7, 2023
@mahmoudadel54 @offtherailz
Fix #9763. long string tooltip applied statically to components (#9793)…
08a5d7f 
… (#9800)

* Fix #9763. long string tooltip applied statically to components

* Fixed tests

Co-authored-by: Lorenzo Natali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV88 MV88 MV88 approved these changes

Assignees

@offtherailz offtherailz

Labels
C040-COMUNE_GE-2023-CUSTOM-SUPPORT Internal
Projects
None yet
Milestone
2023.02.01
4 participants
@offtherailz @ElenaGallo @MV88 @tdipisa